ENT-12600: Document and refactor compile-options #1744
Conversation
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
build-scripts/compile-options
Outdated
| nova-*-debian-*) | ||
| ROLE=hub | ||
| ;; | ||
| nova-*-opensuse-*) |
There was a problem hiding this comment.
we don't support hub on opensuse.
There was a problem hiding this comment.
remove nova--opensuse- setting ROLE=HUB eh? maybe you did in a later commit
larsewi
force-pushed
the
compile-options
branch
2 times, most recently
from
cba2b09 to
7a5ab4c
Compare
|
Build with exotics (no tests) |
| # Embedded DB selection | ||
| EMBEDDED_DB="lmdb" |
There was a problem hiding this comment.
I think we want to keep this option.
There was a problem hiding this comment.
Why? It's not really an option. It's a variable holding a hard coded string. You cannot override it without modifying the script.
larsewi
force-pushed
the
compile-options
branch
from
d4fc6b8 to
61170dd
Compare
|
Ping @craigcomstock |
build-scripts/compile-options
Outdated
| nova-*-debian-*) | ||
| ROLE=hub | ||
| ;; | ||
| nova-*-opensuse-*) |
There was a problem hiding this comment.
remove nova--opensuse- setting ROLE=HUB eh? maybe you did in a later commit
|
@cf-bottom Jenkins please :) |
|
Note to self. Investigate why we get on RHEL 8 |
Signed-off-by: Lars Erik Wik <[email protected]>
We don't really build with something else then lmdb. Hence, we don't need the option to build with something else. Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
This auto detect role code is weird. It tries to detect whether to build a hub or agent package based on the platform it's being built for. In many places it even decides to build hub packages for platforms where it's not supported. I wonder if life will just go on if I remove it. Signed-off-by: Lars Erik Wik <[email protected]>
It makes it easier to read diffs. Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
force-pushed
the
compile-options
branch
from
61170dd to
8b44adc
Compare
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12587/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12587/ |
|
This PR will get major merge conflicts soon. I'll manually reapply the changes needed later and reopen. |
Uh oh!
There was an error while loading. Please reload this page.